Re: Don't ask for confirmation on "undo add"

On 11.08.2010 13:58, Ulrich Eckhardt wrote:
> Greetings!
>
> If I "undo add" some file, this doesn't cause any changes that can't be
> trivially undone. Similar to e.g. "add" or "delete", this only marks the
> changes in the SVN metadata, no content or modifications are lost. Therefore,
> there is also no need to ask "Are you really sure?" when you "undo add"
> something.

There's a small problem here:
the "undo add" does a revert. Of course as you mentioned for added items
this isn't a problem at all.
But the context menu shows "undo add" also for multiple selections, and
for multiple selections the menu items shown are determined by the item
that was right-clicked on. Which means you could have a selection of
e.g. three items, two of them modified and the added one. Then you
right-click on the added one and you'll get the "undo add" menu option.
In that case, not showing the revert dialog actually *could* be harmful.

And no, we can't check the status of all items in a multi-selection for
the context menu: that's just way too expensive and the menu wouldn't
even show up (it times out) if the multi-selection is huge.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2645735
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].