[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Don't ask for confirmation on "undo add"

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Wed, 11 Aug 2010 21:48:39 +0200

On 11.08.2010 13:58, Ulrich Eckhardt wrote:
> Greetings!
> If I "undo add" some file, this doesn't cause any changes that can't be
> trivially undone. Similar to e.g. "add" or "delete", this only marks the
> changes in the SVN metadata, no content or modifications are lost. Therefore,
> there is also no need to ask "Are you really sure?" when you "undo add"
> something.

There's a small problem here:
the "undo add" does a revert. Of course as you mentioned for added items
this isn't a problem at all.
But the context menu shows "undo add" also for multiple selections, and
for multiple selections the menu items shown are determined by the item
that was right-clicked on. Which means you could have a selection of
e.g. three items, two of them modified and the added one. Then you
right-click on the added one and you'll get the "undo add" menu option.
In that case, not showing the revert dialog actually *could* be harmful.

And no, we can't check the status of all items in a multi-selection for
the context menu: that's just way too expensive and the menu wouldn't
even show up (it times out) if the multi-selection is huge.


   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2010-08-11 21:48:54 CEST

This is an archived mail posted to the TortoiseSVN Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.