[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Not really a bug, but an interesting warning

From: Jean-Marc van Leerdam <j.m.van.leerdam_at_gmail.com>
Date: Fri, 8 May 2009 11:15:58 +0200

Hi Stefan,

2009/5/8 Stefan Küng <tortoisesvn_at_gmail.com>:
> Jean-Marc van Leerdam wrote:
>> Somehow (the svn library or TSVN) fails to detect that this type of
>> relocation really is changing the path to the server and not the path
>> inside the working copy.
>>
>
> For file:// urls, it is simply not possible to determine whether the url
> changes inside or outside a repository, because a file:// url doesn't
> have a domain part. That's why the warning is shown: it's a warning
> because TSVN can't be sure.

True, except that I cannot imagine that a change from file:///X: to
file:///Y: can ever qualify as 'inside a repository'.

Isn't it possible (and not that costly) to walk up the new path,
testing if the folder is still recognised by svn as a valid repository
folder and as soon as svn reports 'huh? I don't recognise this' you
know you are outside the repo. If the only differences between old and
new are to the left of the last matched folder then it is a true
relocate, if it is not, then the warning is shown.

Again, there may well be valid reasons why this is not feasible
(server or network folder unavailable at the moment of relocate being
one of them), but attempting some sort of validation could help here.

OTOH, relocate is not the most frequently used command I guess. Having
a warning that may be unneeded and can be ignored anyway doesn't hurt
too much.

-- 
Regards,
Jean-Marc
--
.       ___
.  @@  // \\      "De Chelonian Mobile"
. (_,\/ \_/ \     TortoiseSVN
.   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
.   /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2108711
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2009-05-08 11:17:44 CEST

This is an archived mail posted to the TortoiseSVN Users mailing list.