[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Your working copy has local modifications

From: Lars <larzeb_at_gmail.com>
Date: Tue, 21 Apr 2009 14:05:36 -0700 (PDT)

I think you're right - this feature was added for internal use in my
company, where we own the server and notify users of the limitations you
describe...
Nevertheless, I did learn a lot about this code, and I would like to join
the project as a developer - if think that's possible, I'd love to hear from
you.
Thanks,
   Ishay Peled.

On Tue, Apr 21, 2009 at 10:38 PM, Stefan Küng <tortoisesvn_at_gmail.com> wrote:

> On Tue, Apr 21, 2009 at 20:13, Stefan Küng <tortoisesvn_at_gmail.com> wrote:
> > Ishay Peled wrote:
> >> Stephan,
> >> This is a patch against the trunk. Please have a look at it
> >
> > Thanks a lot for your patch. Works as advertised.
> >
> > But before I commit that change, I have to make some changes. While as I
> > said it works as you said, the UI can be improved in some parts:
> >
> > * the search properties dialog is resizable, but the controls don't
> > resize with the dialog
> > * code needs some cleanup
> > * the dialog mentions "search properties", but it doesn't search for
> > properties but is used for filtering file paths/urls
> > * if a search doesn't return any matches, the repobrowser crashes
> > * the range results dialog could use a progress bar
> > * variable/method names need improving, some have names that don't match
> > their use/function
> >
> > This will take me a while to clean up...
>
> On second thought, after playing a while with this feature and
> cleaning up a lot of code:
> I don't think this is a good feature after all, for several reasons:
>
> * while I like the search result dialog, this for one takes ages to
> complete (searching over 84 revisions on my repository accessed over
> my LAN(!!) takes 7 minutes) and also puts a major stress on the
> server.
> * filtering in the repo browser is also slow, and there's no good way
> to show what exactly is filtered for after the search is finished
>
> Considering all this (speed and stress), I don't think we should
> include such a feature in TSVN: if the feature is there, people will
> use it and complain about the speed, and admins will try to kill us
> for 'killing' their server.
>
> Such a search feature has to be implemented on the server directly,
> not on the client side.
>
>
> Stefan
>
> --
> ___
> oo // \\ "De Chelonian Mobile"
> (_,\/ \_/ \ TortoiseSVN
> \ \_/_\_/> The coolest Interface to (Sub)Version Control
> /_/ \_\ http://tortoisesvn.net
>
> ------------------------------------------------------
>
> http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=1847838
>
> To unsubscribe from this discussion, e-mail: [
> users-unsubscribe_at_tortoisesvn.tigris.org].
>

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=1848772

To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2009-04-22 07:00:19 CEST

This is an archived mail posted to the TortoiseSVN Users mailing list.