Re: Search feature addition

Ishay Peled wrote:
> Stephan,
> This is a patch against the trunk. Please have a look at it

Thanks a lot for your patch. Works as advertised.

But before I commit that change, I have to make some changes. While as I
said it works as you said, the UI can be improved in some parts:

* the search properties dialog is resizable, but the controls don't
resize with the dialog
* code needs some cleanup
* the dialog mentions "search properties", but it doesn't search for
properties but is used for filtering file paths/urls
* if a search doesn't return any matches, the repobrowser crashes
* the range results dialog could use a progress bar
* variable/method names need improving, some have names that don't match
their use/function

This will take me a while to clean up...

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=1846783
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].