[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: After update file still on list

From: David Balažic <david.balazic_at_hermes-softlab.com>
Date: Fri, 6 Mar 2009 15:59:24 +0100

Stefan Küng wrote:

> David Balažic wrote:
> > Stefan Küng wrote:
> >
> >> David Balažic wrote:
> >>> Stefan Küng wrote:
> >>>
> >>>> David Balažic wrote:
> >>>>> Stefan Küng wrote:
> >>>>>
> >>>>>> David Balažic wrote:
> >>>>>>> TortoiseSVN 1.5.9.15518 32-bit
> >>>>>>>
> >>>>>>> In the "check for Modifications" windows, an remotely
> >>>> modified file
> >>>>>>> does not disappear from the list, after calling Update on it.
> >>>>>> Hit F5 to refresh the view.
> >>>>> No, that removes all remote changes. Then I have to click
> >>>> again "Check repository" to get them back.
> >>>>> I also noticed now, that localy changed files also do not
> >>>> disappear from the list after bein commited.
> >>>>> I vaguelly remember that they did so in previous versions...
> >>>> Nope, that never worked that way.
> >>>>
> >>>> Because: how would the CfM dialog even know that an
> >>>> update/commit/whatever was successful? That is done in a
> >>>> separate thread.
> >>> And communication between threads will be invented only
> >> next year ;-)
> >>> I know this is not 5 minutes of work... I program myself.
> >> After you update a folder or a file, what status does it have
> >> (assuming the update was successful)?
> >
> > "up-to-date" (that is : no remote changes)
>
> Nope. Well, the *remote* status would be 'normal', yes. But what would
> the local text and property status be? Could be 'normal', could be
> 'conflicted', could be 'modified', could be ...

Yes. If the user would modify it the same time he is updating it.
Which is done very rarely.

So the current state is:
 - always wrong CfM window after update
After the proposed change (remove remote modified files that were updated)
 - wrong CfM in 1% of cases

Afterall why are reverted files removed from the list ?
The user could have changed them again and the list would be wrong...

The code is following two logics here, without any explanation, why is one good
in one case, and the other in other case.

BR,
David

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=1277636

To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2009-03-06 16:00:17 CET

This is an archived mail posted to the TortoiseSVN Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.