2009/2/13 <ishitori_at_bk.ru>:
>>> It seems nobody knows it :(
>
>>You have waited 3 days for a feature request to be implemented?
>
> It wasn't a feature request :) Of course I understand that it is impossible to do something big like this in 3 days... I just wanted to know if it is can be done manually by me via configuring or writing custom scripts. But it seems the answer is: no, it cannot be done - source code must be modified for this
Correct.
>> Why don't you just edit the log message when the commit is reviewed?
>
> Yes, it is a possible solution. But if reviewer field is separate then it could be used in different ways. Imagine, I could calculate statistics of how many revisions were reviewed, whose and by whom. Of course it can be done via analyzing log messages by regular expressions, but it seems more cumbersome.
>
> That's why storing "reviewer" in a separate property is better. But I also need to see it directly in the commit list, which seems can be done only if this value is copied to log message. So, I would need to update log message too. And I want this to be done automatically when custom property is filled. If it is cannot be done I would forget about custom property and use log message.
I can see why having a reviewer field might be useful, but you can
also imagine 100 people coming up with 100 different ideas about what
would be a useful feature to add to the commit dialog, but there is no
room for them all. So unless you can come up with a generic solution
that can be adapted to many different needs it is very unlikely that
you will see this.
Editing the log message and using a regex to extract the values _is_ a
perfectly generic solution, and not really that hard to do. The only
downside I can see is that if someone mis-types "Reviewed" as
"Reveiwed" then the regex will not catch it.
It *may* be possible to add a generic regex property to TSVN which
works like bugtraq:logregex to validate and highlight content in the
log message, so at least you have a visual indication when the message
is entered correctly.
Simon
--
: ___
: oo // \\ "De Chelonian Mobile"
: (_,\/ \_/ \ TortoiseSVN
: \ \_/_\_/> The coolest Interface to (Sub)Version Control
: /_/ \_\ http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=1150139
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2009-02-13 11:33:09 CET