[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: bug: diff adding newline at end of file when changing lines

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Thu, 22 Jan 2009 18:53:37 +0100

tsvn_at_alagazam.net wrote:
>>>> i have a problem using "diff" of TortoiseSVN and asked on the
>>>> developers mailing list. Since no one responds their i thought about
>>>> sending it to the users mailing list.
>>>>
>>>> I have local modifications in a text file and look at the diff with
>>>> TortoiseSVN. Then i select one modified line and choose "Use this
>>>> text block" and save the file.
>>>>
>>>> I would expect that only the selected line should change, but
>>>> additionally the saved file now has a newline appended at the end of
>>>> the file.
>>>>
>>>> Is this a known bug or did i make something wrong?
>>>> Can someone reproduce this problem?
>
> I still have the original posters problem in TSVN version 1.5.6, Build 14908.
>
> It seems that a bug #336 is filed on this topic and that it's fixed i R8836.
> But maybe you just fixed the file loading, and it's the saving that's the problem.
>
> To reproduce this error:
> * create a one character text file (without newline)
> * copy this file
> * select both files in explorer
> * do a diff (they are the same, aren't they?)
> * right click in the line in the left file and select "Use this whole file" or "Use this text block"
> * save the changes using toolbar icon
> * refresh using toolbar icon
>
> Now the right hand file has a newline at the end.

Fixed in r15160.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=1043383
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].

Received on 2009-01-22 18:53:57 CET

This is an archived mail posted to the TortoiseSVN Users mailing list.