[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Issue Tracker Plugin and Recent Messages

From: Stefan Kueng <tortoisesvn_at_gmail.com>
Date: Tue, 06 Jan 2009 19:25:37 +0100

David Henderson wrote:
> Hi Stefan,
>
> I've just found a small bug in the issue tracker implementation (that
> you did some work on in early December):
>
> To reproduce (using yesterday's nightly build):
>
> 1) Do 1 commit with a BugzID using the issue tracker plug-in.
> 2) Open the commit dialog for a second commit
> 3) Click the recent messages button and select the previous message.
> The Issue box will be filled with the value from the previous entry.
> 4) Click OK. The message "Only Numbers (optionally separated by commas)
> are allowed!" will be shown in a tooltip.
>
> There are no characters before or after the number in the box. To
> complete the commit, you need to make a change within the issue # box.

Strange. I can't reproduce this.
Also, the code responsible for the check gets the text from the edit box
directly, not from a variable:

        CString id;
        GetDlgItemText(IDC_BUGID, id);
        if (!m_ProjectProperties.CheckBugID(id))
        {
                ShowBalloon(IDC_BUGID, IDS_COMMITDLG_ONLYNUMBERS, IDI_EXCLAMATION);
                return;
        }

which means that if the text is shown in the issue # box, it will be
used and it should not be necessary to edit the text in there first.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=1008166
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].

Received on 2009-01-06 19:27:28 CET

This is an archived mail posted to the TortoiseSVN Users mailing list.