[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: BUG Commit within samba-network dir

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Wed, 27 Aug 2008 11:30:21 +0200

On Wed, Aug 27, 2008 at 10:03, Simon Large
<simon.tortoisesvn_at_googlemail.com> wrote:
> 2008/8/27 Stefan Küng <tortoisesvn_at_gmail.com>:
>> Ben Voigt wrote:
>>>> Have you considered that the change in TSVN may have exposed a problem
>>>> with Samba?
>>>>
>>>> If it works properly locally, and breaks on Samba, the problem must be
>>>> with Samba and/or the network. TSVN doesn't see the local and remote
>>>> paths differently.
>>>
>>> This ("the problem MUST be") is also false, for the same reasoning.
>>>
>>> "works locally" is not comprehensive enough testing to rule out bugs.
>>> For example, the difference in time taken to complete I/O operations
>>> could easily affect the behavior of a race condition. Overlapped I/O
>>> may complete in a different order over the network. Packet
>>> fragmentation can cause partial completion of operations. Virus scans
>>> could interact with network traffic. Lost packets could result in
>>> failed operations and trigger error handling and retry code that never
>>> gets exercised locally (this should not be dismissed as a "problem
>>> with the network") There are a LOT of other factors involved with
>>> accessing file shares beyond just Samba.
>>
>> Not really.
>> Sure, the comparison between Samba and local harddrive access is not the
>> same and this could still be a bug in Subversion. But all your reasoning
>> goes away once you compare Samba shares and Windows shares: we never
>> heard of any problems with Windows network shares, only with Samba
>> shares. And those two have the same timing factors.
>
> Before we descend into too much mud slinging, it is likely that the
> change is in the SVN library and not TSVN itself. There have been

Yes. The change is in the library, because it now uses some of the
same techniques for locking and accessing files for the working copy
as are used for the repositories. And you know the deal with having
repositories on network shares.

Stefan

-- 
 ___
 oo // \\ "De Chelonian Mobile"
 (_,\/ \_/ \ TortoiseSVN
 \ \_/_\_/> The coolest Interface to (Sub)Version Control
 /_/ \_\ http://tortoisesvn.net
Received on 2008-08-27 11:30:37 CEST

This is an archived mail posted to the TortoiseSVN Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.