[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bug report for SubWCRev

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Sun, 17 Aug 2008 20:34:15 +0200

Martin Dummer wrote:
>
>> Martin Dummer wrote:
>>
>>> Hey,
>>>
>>> I think I found a bug in SubWCRev.exe. Using the template scheme with
>>> source and dest. file, SubWCRev produces nonsense if all keywords are
>>> specified.If only one of them is used, the program works fine. The
>>> keywords are copied from the help text as the website does not list
>>> them. For my repository the result looks like this:
>>>
>>> $WCREV$
>>> $WCDATE$
>>> $WCDATE=$
>>>
>> This is wrong. If you use $WCDATE=$, you have to specify a time
>> formatting string after the = char. For example:
>> $WCDATE=%a, %d %B %Y$
>>> $WCRANGE$
>>> $WCURL$
>>> $WCNOW$
>>> $WCNOW=$
>>>
>> same here with $WCNOW=$.
>> Stefan
>>
>>
> Sorry, I didn't explain well enough. It is incorrect yes, but in my
> opinion SubWCRev should recognize if there is a string supplied or not
> instead of messing up the code (even outside the "$" tags). I tried to
> supply a valid string for german time format which looks like this:
>
> $WCDATE=%d.%m.%Y - %T$
>
> I think it is correct, but SubWCRev crashes completely without error
> message. It would be nice if the crash could be avoided, even in case of
> an erroneous format string .But thanks for your help so far

I agree that SubWCRev should not crash. But your string is still wrong:
%T is not a valid formatting code.
See http://msdn.microsoft.com/en-us/library/fe06s4ak(VS.71).aspx for
valid formatting codes.

The problem is however that the strftime() function crashes when invalid
formatting codes are passed to it. Maybe I can find a way around that,
but I won't promise anything here...

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net

Received on 2008-08-17 20:34:51 CEST

This is an archived mail posted to the TortoiseSVN Users mailing list.