RE: Re: BUG: GUI freeze during renaming

Stefan, I haven't taken time to look at the code at all, but this seems like a situation where you should separate the UI renaming code from the actual rename operation. In other words, once the user types in the name and presses enter or clicks somewhere else, post a message that will be processed after all the cleanup code is run. The current flow of code can finish the cleanup work and return the UI to a known state. Then, you process the message that has been waiting, and perform the actual rename work.

John

-----Original Message-----
From: Stefan Küng [mailto:tortoisesvn_at_gmail.com]
Sent: Monday, July 14, 2008 1:03 PM
To: users_at_tortoisesvn.tigris.org
Subject: Re: BUG: GUI freeze during renaming

svn-user wrote:
> Hi!
>
> I am using TortoiseSVN rev. 13471 (nightly build). The following
> result is also reproducible with the stable build.
>
> If you rename a file in the Repo Browser via the following steps:
> 1) open the Repo Browser
> 2) navigate to a file
> 3) left-click the file to select
> 4) right-click the context-menue
> 5) select the command Rename
> 6) rename the file
> 7) left-click in the Repo Browser-dialog then the Enter Message-dialog
> opens with the busy cursor shown.
> You can enter something into the text field, but you are not able to
> click on the buttons.
> It looks like another modal dialog is opened...
>
> This does not happen if you press the ENTER-key after step 6.

While I can reproduce this, I have no idea on how to solve this.
One problem is that debugging doesn't help much: as soon as the dialog looses focus, the issue goes away (i.e., if it hangs, just switch to another window and back again, and it won't hang anymore).

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe_at_tortoisesvn.tigris.org
For additional commands, e-mail: users-help_at_tortoisesvn.tigris.org