[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: TMerge EOL icons look ugly on W2K

From: Simon Large <simon.tortoisesvn_at_googlemail.com>
Date: Sun, 13 Jul 2008 15:32:28 +0100

2008/7/12 Stefan Küng <tortoisesvn_at_gmail.com>:
> Simon Large wrote:
>>
>> 2008/7/8 Christian Walther <cwalther_at_gmx.ch>:
>>>
>>> Stefan Küng wrote:
>>>>
>>>> As of r13423, you can switch to the line drawing
>>>
>>> OK, that looks much better! Screenshot attached for comparison for the
>>> curious. The CRLF arrow is a bit asymmetric, but the non-intrusiveness is
>>> a
>>> big improvement. I can live with the lack of antialiasing considering
>>> that
>>> on Windows (2000 at least) most things aren't antialiased. Thanks!
>>
>> OK, I see why you think they're ugly, Stefan, but with a little change
>> they could be fine, and IMHO better than the icons. The attached
>> screenshots show TMerge and Notepad2 displaying the same file. I don't
>> like Notepad2's line-ending representation - that really would be
>> intrusive - but its tab representation looks good to me.
>>
>> So in TMerge I think you need to:
>> 1. Make the arrow heads smaller, maybe half the size they are now.
>> 2. Use 45 degree angle for all the diagonals. Easy to align, and draws
>> smoothly.
>> 3. Make sure the lines don't overlap to give a blob at the arrow head.
>> 4. Make the CRLF arrow symmetrical.
>> 5. Reduce height of LF and CRLF arrows just a little so there is a gap
>> between them on adjacent lines.
>>
>> Then I think it will look good :-)
>
> They should look better as of r13471.

Great! I like those much better than the icons now :-)

One small comment - the arrow head on the tab could be smaller to
match the arrow heads on the line endings.

Can this change be merged back to the 1.5.x branch? It's not a bug
fix, but it's not high risk either.

Simon

-- 
: ___
: oo // \\ "De Chelonian Mobile"
: (_,\/ \_/ \ TortoiseSVN
: \ \_/_\_/> The coolest Interface to (Sub)Version Control
: /_/ \_\ http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe_at_tortoisesvn.tigris.org
For additional commands, e-mail: users-help_at_tortoisesvn.tigris.org
Received on 2008-07-13 16:32:45 CEST

This is an archived mail posted to the TortoiseSVN Users mailing list.