[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Removing revision properties asks for commit message and doesn't display hook error message

From: J J <eggsgloriouseggs_at_gmail.com>
Date: Fri, 27 Jun 2008 11:44:14 -0500

>>> My repository has a pre-revprop-change hook in place that prevents all
>>> modifications to revision properties. It works fine (i.e. prevents
>>> the action and displays the error message) when I try to edit or add
>>> revision properties via TortoiseSVN. However when I try to remove a
>>> property it asks me for a commit message (which should be required)
>>> and then just refreshes the Properties window without any change. No
>>> error message is displayed.
>>>
>>> Is this a known issue?
>>
>> I can't reproduce this here. If I set the pre-revprop-change hook script to
>> return -1 (indicating an error), I get a nice messagebox showing me that the
>> removal of the revision property failed and the error message piped to
>> stderr by the script.
>>
>> Do you have more information about your setup/script/versions? And I assume
>> you used the log dialog, right-click, "Show revision properties" for this?
>
> I get two different behaviors depending on how I do it.
>
> 1) Right click > Show Log. Right click on revision > Show revision
> properties. Highlight property and click Remove. "Enter Log Message"
> dialog appears. Click OK. Then a dialog titled "Microsoft Visual C++
> Runtime Library" appears with the following text.
>
> Runtime Error!
>
> Program C:\Program Files\TortoiseSVN\bin\TortoiseProc.exe
>
> This application has requested the Runtime to terminate it in an unusual way.
> Please contact the application's support team for more information.
>
> Everything is unresponsive after this, and eventually a
> "TortoiseProc.exe" dialog appears saying "TortoiseProc.exe has
> encountered a problem and needs to close. We are sorry for the
> inconvenience." I can click Debug or Close.
>
> 2) Within Repository Browser right click on a folder and select Show
> revision properties. Highlight property. Click Remove. "Enter Log
> Message" appears. Click OK. "Setting properties" progress dialog
> appears briefly. Then Properties window refreshes with all properties
> still present and no error.
>
> I installed from the file TortoiseSVN-1.5.0.13316-win32-svn-1.5.0.msi
> if that helps at all.
>
> Justin
>

My hook is as follows.

#!/bin/sh
echo "Changing revision properties is prohibited by company policy" >&2
exit 1

I've always exited with a status of 1 for failure and 0 for success.
I get the exact same results if I change it to return -1 though.

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe_at_tortoisesvn.tigris.org
For additional commands, e-mail: users-help_at_tortoisesvn.tigris.org
Received on 2008-06-27 18:44:21 CEST

This is an archived mail posted to the TortoiseSVN Users mailing list.