[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [bug] TSVN 1.5RC2 Pasting an URL into commit dialog corrupts preceding message text

From: Stefan Ku <tortoisesvn_at_gmail.com>
Date: Sat, 07 Jun 2008 17:34:29 +0200

Konstantin Kolinko wrote:
> Summary:
> ~~~~~~~~
> In TortoiseSVN 1.5.0-RC2 (32-bit)
> when pasting an URL into the message field of Commit dialog, the text
> preceding the URL may become corrupted.
>
> To reproduce the issue the following seems to be essential:
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 1. The text preceding the URL must end with a colon (":") followed by
> a whitespace character (e.g.: space or end of line).
> 2. The text preceding the URL must use i18l characters (e.g.: Cyrrilic ones),
>
> I was not able to reproduce the behavior with English characters only.
>
> Steps to reproduce:
> ~~~~~~~~~~~~~~~
> 1. Open SVN Commit dialog
> 2. Paste the following 4 lines of cyrillic text into the message field:
> : _
> 2: _
> :
> _
>
> Result of this step:
> http://img386.imageshack.us/img386/8456/tsvn15rc2commitmsgstep1vn4.png
>
> 3. Replace the '_' symbols in the message with the following URL
> (using copy & paste):
> http://www.example.com
>
> Result of this step:
> http://img259.imageshack.us/img259/8241/tsvn15rc2commitmsgstep2ro6.png
>
> 4. Observed behavior:
> 4.1. The Cyrillic text in lines 2 and 3 is corrupted
> 4.2. The blue highlight area of the URL in lines 1, 2 is
> mispositioned. The ".com" part of the url is not highlighted.
>
> It looks like the algorithm that calculates the highlight area of the
> url is the culprit.

Thanks for the detailed report and the reproduction recipe!
Fixed in r13161

In case you're worried that your log message is messed up: it's only
*shown* messed up. It would still get committed correctly (it's the
styling of the URL that would mess up the display).

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net

Received on 2008-06-07 17:34:53 CEST

This is an archived mail posted to the TortoiseSVN Users mailing list.