[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: TSVN 1.5 + neon enabled MIT

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Sun, 20 Apr 2008 14:22:30 +0200

Ludek Finstrle wrote:
> Sat, Apr 19, 2008 at 10:35:16AM +0200, Stefan Küng napsal(a):
>> Ludek Finstrle wrote:
>>> Fri, Apr 18, 2008 at 09:48:28PM +0200, Stefan Küng napsal(a):
>>> He pointed me the way TSVN should use neon dll (instead staticaly linked).
>>> Then the end users should choose between two neon.dll (one SSPI, another
>>> GSSAPI enabled). Is it acceptable solution for TSVN?
>> Sorry, no. I won't create separate dlls if I can link that stuff
>> statically. Especially something that uses any kind of security
>> (openssl, sspi authentication, ...). The risk of malware interferring
>
> I'm sorry to be in opposite but you're using runtime linkage of sspi auth.

No I don't. Please check our build script if you don't believe me.
If you're referring to the SASL dlls, then the only reason I don't link
those statically is because they won't build that way.

> Let's look into neon source code. There is LoadLibrary for sspi. I don't
> know why sspi is ok for neon with runtime linkage while gssapi not.
>
>> with dlls is too high, and I also really hate the problems which arise
>> from using dlls (ever heard of "dll hell"?).
>
> TSVN should use LoadLibrary with full path to neon library. So I see no
> dll hell then.

Check the docs about LoadLibrary(), especially the section on the
different load paths on different OS versions.
Also, it's Subversion that accesses the functions of neon. So no way for
TSVN to interfere with that.

> I see one advantage in two neon dlls. The user should choose which auth
> they'll use in TSVN settings dialog instead of playing with PATH variable.

See above. I have no intention on having our build system patch the
Subversion library in several places just for that.

I'm sorry, but you can argue here as long as you want, you won't change
my opinion about dlls. Sure, *you* would get the feature that you want,
but *I* will have to deal with the thousands of users having problems
because of the dlls.
Windows is a hostile environment for applications. If you haven't
realized that yet, then you haven't really written a program that's used
by a lot of users.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net

Received on 2008-04-20 14:22:52 CEST

This is an archived mail posted to the TortoiseSVN Users mailing list.