[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: TSVN 1.5 + neon enabled MIT

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Fri, 18 Apr 2008 21:48:28 +0200

Ludek Finstrle wrote:
> Hi,
>
> I update the patch as I mentioned in previous e-mail. I have already
> sent the new patch to the neon developer. I don't plan to change the
> patch if there is no comments from developers.
>
> I upload my final version here:
> http://rapidshare.com/files/108451874/TortoiseSVN-1.5.0.12411-dev-win32-svn-1.5.0-dev-mit-gssapi.msi.html
>
> Steps for developers are the same. New patch attached.
>
> Thu, Apr 17, 2008 at 01:36:43PM +0200, Ludek Finstrle napsal(a):
>> I think I found way to support MIT GSSAPI in TSVN 1.5. I create
>> patch only for neon. It isn't finall version. The final one I'll try
>> put into neon HEAD devel. But I need this feature in TSVN 1.5 so
>> I send it here first.
>>
>> I upload TSVN (1.5 beta 1) msi installer with MIT GSSAPI enabled:
>> http://rapidshare.com/files/108184155/TortoiseSVN-1.5.0.12411-dev-win32-svn-1.5.0-dev.msi.html
>
> I have removed this file from rapidshare.
>
>> Here is the way for developers (building from source):
>> - download mit kerberos for windows SDK zip
>> - unzip the SDK into the SVN\common and rename to kerberos
>> - apply attached patch neon_build_3.patch to SVN\TortoiseSVN\ext\build dir
>> - apply attached patch neon_src_3.patch to SVN\TortoiseSVN\ext\neon dir
>> (I was unable to create only one patch with TSVN)
>> - distribute the change from SVN\TortoiseSVN\ext\neon\config.hw.in to
>> SVN\TortoiseSVN\ext\neon\config.hw and SVN\TortoiseSVN\ext\neon\config.h
>> (add #define HAVE_GSSAPI and #define HAVE_GSSAPI_GSSAPI_H)
>>
>> That's all.
>>
>> What do you think, is it possible to put this kind of patch into HEAD
>> of TSVN? There is no additional dependency as the patch uses dynamic
>> loading with LoadLibrary and GetProcAddress to gssapi32.dll.
>
> Please, could some TSVN developer say if it's suitable or not?

It looks fine to me. But I don't want to have neon patched for a release
TSVN build. If neon accepts your patch and a new version of neon with
this patch applied gets released, I'll include this in TSVN.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net

Received on 2008-04-18 21:48:41 CEST

This is an archived mail posted to the TortoiseSVN Users mailing list.