Re: Accessing %VERSION% parameter in update hook batch script

On 06/03/2008, Stefan Küng <tortoisesvn_at_gmail.com> wrote:
> Simon Large wrote:
> > On 06/03/2008, Jean-Marc van Leerdam <j.m.van.leerdam_at_gmail.com> wrote:
> >> Hi Paul,
> >>
> >> Please post the command line you've entered in the settings dialog.
> >> You are supposed to place the %xxx% placeholders in that command line.
> >> So if you enter
> >>
> >> pre-update.bat 1 2 3 %PATH%
> >>
> >> Then the fourth parameter in the .bat will contain the path.
> >
> > Correct. The values to be passed are specified on the command line.
> > The list in the docs shows the values available, not what is actually
> > passed.
> >
> > But this brings up a very valid point. The subversion server hooks
> > always pass the parameters on the command line in fixed positions.
> > Specifying the params in TSVN settings is perhaps more flexible, but
> > the difference from Subversion hooks will likely cause a lot of
> > confusion.
> >
> > Also, it places the burden of specifying the parameters on the person
> > who installs the hook. If you want everyone in the organisation to use
> > a client-side post-update hook, it is easy to add that hook script to
> > the repository and tell everyone to make sure it is called. But if
> > they also have to type in the parameters in the correct order it is a
> > lot more error prone. In this case, subversion's method wins because
> > all you have to do is install the script and it is up to the script to
> > know where the params are.
>
>
> Should we change our hook scripts to always pass *all* params in a
> defined way?

That would make the behaviour more like svn hooks, and we could also
provide hook templates which would help with the documentation.

Are there any disadvantages? What do others think?

Simon

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe_at_tortoisesvn.tigris.org
For additional commands, e-mail: users-help_at_tortoisesvn.tigris.org