bug with {diff,merge}-od[st].vbs and blanks in filenames

Hi,

there is a bug in handling blanks in the above diff/merge scripts:

- open log window of a odt/ods file with blanks in it
- mark _two_ revisions
- issue 'compare revisions'
- the two revisions are fetch from the repository and saved in
   the temp directory
- blanks in file names are already transformed to "%20"!
- the script is called with the file names with "%20" in them
- after transforming the file names, they still contain
   "%20"
- and OOo fails expectedly to open them

Changing the scripts:

sBaseDoc=Replace(sBaseDoc, "\", "/")
sBaseDoc=Replace(sBaseDoc, ":", "|")
sBaseDoc=Replace(sBaseDoc, "%", "%25")
sBaseDoc="file:///"&sBaseDoc
sBaseDoc=objUriTranslator.translateToInternal(sBaseDoc)
sNewDoc=Replace(sNewDoc, "\", "/")
sNewDoc=Replace(sNewDoc, ":", "|")
sNewDoc=Replace(sNewDoc, "%", "%25")
sNewDoc="file:///"&sNewDoc
sNewDoc=objUriTranslator.translateToInternal(sNewDoc)

fixed the issue, but I'm not sure if this does not introduce anything new.

Also the behaviour of "comparing two revisions" in a repository is
inconsistent with "comparing base with a revision".
In this case the file is created in the temporary directory without
transforming " " to "%20".

Hardy

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe_at_tortoisesvn.tigris.org
For additional commands, e-mail: users-help_at_tortoisesvn.tigris.org
Received on 2008-02-28 10:21:24 CET