[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Revision graph fails with restricted domain auth

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: 2007-09-19 20:18:15 CEST

David W. Wilson wrote:
> I whined:
>
> >> [I have an issue with TSVN revision graphs, specifically that the
> revision graph code
> >> accesses the svn repository root where the user may not have privs,
> which causes the graph to
> >> fail. See previous posts on this thread for more detailed description.]
>
> Stefan Küng replied:
>
> > To generate the revision graph, TSVN must fetch the verbose log of the
> > repository root. It isn't enough to just get the log from the path you
> > request the graph for, it *must* be the repository root.
> > So, if you prevent read access to the repository root, it's not possible
> > to show the revision graph.
>
> Out of curiosity, what information is maintained in this verbose log?

The same information you see in the TSVN log dialog:
* log message, author, ...
* changed paths

> Why should users require
> inaccessible information to view a revision graph of accessible files?
> My immediate feeling is
> that either SVN is overprotecting its verbose log, or else TSVN is
> asking for information it
> really doesn't need in order to generate the portion of the revision
> graph that the user has a
> right to see.

The log for an item only shows those revisions that path got directly
changed. But then the information is missing when that item got
moved/renamed/copied due to a move/rename/copy operation on a parent
item. And the revision graph needs that information.

You can try it yourself: show the log for your /trunk folder. You won't
see any information about copies of /trunk to e.g. /tags/version-XXX.
Those log entries are missing because it didn't affect /trunk directly -
the /trunk folder (or an item below it) wasn't modified.

That's why we need to get the log from the repository root.

> happy at the cost of granting everyone read access in the repository
> root. Fortunately, we don't
> have any source files in the root, otherwise I would have had a much
> harder job convincing my
> manager to accept this compromise.

Most people don't have files in the repository root. At least not if you
follow the recommended folder layout.
But if you revoke the read access to some subfolders, then the revision
graph won't show you copies from those because the log won't show them.
Which shouldn't be a problem really, but just so you know that the
revision graph won't show those and you won't expect it to do that.

> Anyway, thank you for your help. At least I know that the repository
> graph code is not needlessly
> or inadvertently accessing the protected information, even if I disagree
> that it should have to.

When I started the revision graph, I knew that this would be an issue
which I simply can't solve. But it was either that, or no revision graph
at all...

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: users-help@tortoisesvn.tigris.org
Received on Wed Sep 19 20:18:34 2007

This is an archived mail posted to the TortoiseSVN Users mailing list.