[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: SubWCRev causing issues

From: Simon Large <simon.tortoisesvn_at_googlemail.com>
Date: 2007-07-05 11:26:57 CEST

On 05/07/07, Stefan Küng <tortoisesvn@gmail.com> wrote:
> On 7/5/07, Simon Large <simon.tortoisesvn@googlemail.com> wrote:
> > On 05/07/07, Struan Judd <struan@scifi.geek.nz> wrote:
> > > When I upgraded to TortoiseSVN 1.4.4, I started having the following
> > > problem with SubWCRev.
> > >
> > > I use batch scripts to run a full rebuild on the program suite I'm
> > > lead developer for.
> > >
> > > As a part of these scripts I run SubWCRev to update the version
> > > information that is then linked into the Execuables and Assemblies.
> > > These scripts capture the output of SubWCRev into the build log file.
> > >
> > > As of v1.4.4 the SubWCRev output is no longer being captured by a
> > > standard Command shell redirect. The exact command line I use is:
> > > %BaseDir%\Builder\SubWcRev . Assembly.inc-tmpl Assembly.inc >> %BuildLog%
> > >
> > >
> > > Also the new SubWCRev is leaking an Enter key keyboard event (or
> > > something very similar) into the current windows event queue. Which
> > > is quite disconcerting. :-)
> > >
> > > If I try to replicate the error with nested command scripts, it
> > > doesn't happen, but sometimes if I run the same command string from
> > > the command prompt, it does.
> >
> > Both these have been fixed in trunk, but that won't help you much
> > unless you try a nightly build.
> >
> > Stefan, Tobias, are these fixes OK for backport to the 1.4.x branch?
> There's nothing to backport. Those changes happened on trunk, and the
> fix was for trunk. Nothing in SubWCRev changed between 1.4.3 and
> 1.4.4.
> I think he's talking about 1.4.99, where the output stuff has been
> fixed.

Well he said 1.4.4, but not what he upgraded from... oh, I see. The
nightly used to say 1.4.4 as well, didn't it?

> But the enter keypress will be left in there.

I don't understand this one - what is good or bad about putting an
enter keypress in the event queue?

> The problem here is not SubWCRev but how he's using it. It's like
> instead of sending an email with a document attached, you print the
> document, send it by snail mail, scan it back in and run an OCR on the
> document.
> SubWCRev is *not* designed to be used that way. Never parse the output
> of SubWCRev but let it change/replace the text in your files instead.

He is using it to replace text in a file. But he's also sending the
summary that appears on stdout/stderr to his buildlog. I would guess
there's no parsing going on here, just appending useful human-readable
info. I guess it saves having to crawl the WC twice, once for the
include file and once for the build log.

> I won't keep the SubWCRev versions backward compatible for the output
> - I will change the output of SubWCRev when and how I see fit. The
> only thing that will be kept compatible are the command line switches
> and the placeholders which get replaced in the files.

We never made any guarantees about exactly what is displayed in the
output stream, but that's not what he's saying. It's the change from
stdout to stderr (or the otherway around?)


  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
To unsubscribe, e-mail: users-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: users-help@tortoisesvn.tigris.org
Received on Thu Jul 5 11:26:45 2007

This is an archived mail posted to the TortoiseSVN Users mailing list.