[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: intl3_svn.dll & another TSVN dlls

From: George Hazan <george.hazan_at_gmail.com>
Date: 2007-05-23 14:59:36 CEST

   Hello, Stefan!
   Wed, 23 May 2007 10:31:08 +0200 you wrote:

>> Only Shell_NotifyIcon gets called to this moment... Hmm...
SK> What about SHGetFileInfoA in LoadIconsAndTypesThread(), file
SK> src\modules\srfile\fileexistsdlg.c ?

It's being called only during file transfers, but dlls are loaded just when
a contact list appears.

SK> And *that* API will definitely load the overlay extension.
SK> I'm sure there are other places where you load the extensions.

Maybe... I'll try to dig it.

SK> Ok, that of course means the dll's are already loaded, but they're not
SK> used. Problem is: the *shell* loads our dll, and we can't tell the shell
SK> not to.

Yes, that's why I thought about the really tiny dll (10K), which will test
the process name and then load the main dll, if it's needed. Let the shell
load it, no problems.

SK> My guess would be that you don't cleanly free some resources you get
SK> with some shell API call.
SK> And as I just discovered: I'm right.

No, you're not so quite right :)

SK> In your function LoadIconsAndTypesThread(), you don't free/destroy the
SK> icon handle after the call to SHGetFileInfoA - since that API also

They are freed below, in WM_DESTROY handler (lines 324, 325), but I don't
talk about resource leaks.

SK> I don't really know what exactly BoundsChecker tells you about the
SK> memory leak, but I *know* that there is no such leak in the tsvn shell
SK> dll.

Ok, I'll send you a report.

SK> Before you accuse others of bad coding, you really should first check
SK> your own code.

Indeed :)

-- 
WMBR, George Hazan (ghazan@postman.ru) 
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: users-help@tortoisesvn.tigris.org
Received on Wed May 23 15:23:38 2007

This is an archived mail posted to the TortoiseSVN Users mailing list.