[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Paths in patch files

From: Grzegorz Kossakowski <grek_at_tuffmail.com>
Date: 2007-02-08 09:55:05 CET

Tobias Schäfer napisa³(a):
> On Wednesday 07 February 2007 23:16, Grzegorz Kossakowski wrote:
>
>> Hello,
>>
>> The problem is that all paths (Index: etc.) in patch
>> produced by Subclipse are absolute. It's not a big deal for Subclipse on
>> another computer/filesystem because it has option to trim some early
>> segments of path. However, TortoiseSVN tries to apply patch with paths
>> as is and this obviously leads to an error (file not found or so).
>> I've already asked[1] on Subclipse mail list and got response that
>> absolute paths are expected from Subclipse and there is no bug. Now,
>> TortoiseSVN cannot live with that format of patches so I would like to
>> know your opinion on this subject.
>> Which behavior is correct?
>>
>
> TortoiseSVN can apply patches with relative and absolute paths. If the paths
> are absolute they need to be in windows form although both "\" and "/" can
> be used as separators.
>
I'm not getting this. I thought that Subversion is platform-independent
so clients should also produce/treat data (patches in this case) in
platform-independent. How it can be that there is no way to apply patch
created by quite popular client - Subclipse?
> Looking at part of the patch:
>
> Index: /home/grek/c2.2-trunk/blocks/cocoon-forms/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/js/DropdownDateTimePicker.js
> ===================================================================
> --- /home/grek/c2.2-trunk/blocks/cocoon-forms/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/js/DropdownDateTimePicker.js
> (revision 500240)
> +++ /home/grek/c2.2-trunk/blocks/cocoon-forms/cocoon-forms-impl/src/main/resources/org/apache/cocoon/forms/resources/js/DropdownDateTimePicker.js
> (working copy)
>
> The absolute path starts with /home/grek and therefore TortoiseSVN cannot
> map it to an absolute path on the filesystem.
>
> We could do some guessing by looking in the current directory for common
> paths but this would be guessing which is not the intention of absolute
> paths :-)
>
 From my POV all paths should be relative to root folder of checkout but
we don't live in dream-world... As I've said, Subclipse has an option to
trim path and that makes it happy then. Just for the sake of client
compatibility and user's convenience shouldn't it be fixed somehow?

Thank's for your comment.

-- 
Grzegorz Kossakowski
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: users-help@tortoisesvn.tigris.org
Received on Thu Feb 8 09:55:20 2007

This is an archived mail posted to the TortoiseSVN Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.