[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: /notempfile

From: Tobias Schäfer <tobiasschaefer_at_gmx.de>
Date: 2006-09-25 07:04:02 CEST

On Monday 25 September 2006 02:44, Gavin Lambert wrote:
> Instead of doing that, I'd make it /tempfile="whatever path" (similar to
> what I suggested in the original post). That completely divorces the
> tempfile from the /path option, so then there should be absolutely no
> danger of confusion.

Using /path when the file should be deleted afterwards and
alternatively /tempfile when the file should not be deleted by tortoiseproc
seems a bit confusing to me. I prefer always using /path for the path and
optionally passing /tempfile if it is a tempfile. TortoiseProc then knows
it needs to delete the file.

Are there any other opinions?

> If the tempfile always contains just a list of files to act on, then I'd
> go one step further and call it /filelist or something.

It can actually also contain directory names, so /pathlist would be better.

Renaming /path to /pathlist (or filelist) will break all calls of
tortoiseproc which users have created to automate TSVN. I definitely don't
want to do this!

> Then it could
> be documented as such and used when other programs want to pass in
> pregenerated lists of files. (If it's some command-specific weird
> internal format, then it's probably best staying fairly obscure.)

It's unicode.

> Finally, on the whole temp-file-cleanup thing: does the shell extension
> fire-and-forget the call to TortoiseProc, or does it wait around (in a
> separate thread, maybe?) for it to finish? If it has to wait anyway
> then the shell extension could be responsible for cleaning up the temp
> file afterwards. It's always better if the creator of a temp file is
> the one who cleans it up.

No, it doesn't wait. If it would wait the explorer would be blocked while
TortoiseProc is running.

Tobias

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: users-help@tortoisesvn.tigris.org
Received on Mon Sep 25 07:04:49 2006

This is an archived mail posted to the TortoiseSVN Users mailing list.