[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bug: Saving Properties values (over existing file)

From: Jan Linnenkohl <jan.linnenkohl_at_gmx.de>
Date: 2006-09-18 21:57:04 CEST

Hi Stefan,

I think there is then another problem with the loading of property values
from a file.

My way to get the error was the following:

I openend up two properties windows and copied from one to the other by
writing the property in a file names "1"

So I saved on property value and load it in the other dialog.
By saving I tried to overwrite the existing file "1", where the system
breaks down.

I think, the loading inside the "Add property"-dialog is blocking the file.
May be the attached patch close the FileHandle in the right way. I didn't
have a testing TSVN system, so it's just written and not tested.

Jan

Index: EditPropertyValueDlg.cpp
===================================================================
--- EditPropertyValueDlg.cpp (revision 7480)
+++ EditPropertyValueDlg.cpp (working copy)
@@ -324,6 +324,7 @@
                 }
                 delete [] buf;
                 fclose(stream);
+ CloseHandle(hFile);
                 // see if the loaded file contents are binary
                 SetPropertyValue(m_PropValue);
                 UpdateData(FALSE);

From: Stefan Küng
>Jan Linnenkohl wrote:
>> Hi,
>>
>> when I try to save the data in the properties dialog over an existing
>> file I get a greeting from Dr. Watson.
>There's an exception thrown when the existing file is also locked by
>another application or you don't have access permission to that file.
>That's fixed in revision 7532.
>Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: users-help@tortoisesvn.tigris.org
Received on Mon Sep 18 22:03:38 2006

This is an archived mail posted to the TortoiseSVN Users mailing list.