Re: bug in diff parsing

On 4/20/06, Baz <brian.ewins@gmail.com> wrote:

> we experienced some strange problems here where far fewer files were
> being reported as changed in a diff in tortoise and in the command
> line svn. Investigating it a bit, I think there's a bug in how
> tortoise parses unified diffs. Tortoise doesn't list any files changed
> after it encounters lines *inside* a hunk starting '---'. The lines
> that triggered this for us were deleted sql comments (first '-' is
> delete, followed by '--' for the sql comment)
>
> Its easy to reproduce the problem. Create two files, test1.txt,
> test2.txt containing these two lines:
>
> -- this line will trip up tortoise
> this one is ok
>
> Commit these. Now edit *both* files to remove the first line, and
> commit. We're editing both lines here because tortoise won't report
> the second file in the diff, but I don't know which it'll report
> first; making both files trigger the bug means tortoise will omit a
> file either way.
>
> Now show the log for the dir, and compare the two revisions you just
> committed. Tortoise will only show one file changed, but the diff
> output on the command line is:
> $ svn diff -r 9676:9677 http://glacvs/svn/logbugz
[snip]
> I'd report this as a bug but the bug tracker appears to be down
> ("Flyspray was unable to connect to the database. Check your settings
> in flyspray.conf.php")
>
> Any thoughts?

I've mentioned this before: I know there's a bug in the diff parser.
But we don't use that parsing anymore on trunk, because Subversion 1.4
has a nice new API which we now can use instead. That API is much,
much faster because we don't have to do the full diff.

So, the problem is gone on trunk.

Stefan

--
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@tortoisesvn.tigris.org
For additional commands, e-mail: users-help@tortoisesvn.tigris.org