[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Rewrite CLinkControl to fix drdump bug #175094

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Wed, 16 Dec 2015 19:11:20 +0300


The most often reported crash in TortoiseSVN 1.9.3 is problem 175094
[1, 2]: it's reported 152 times just in the first day of release. The
crash happens in
CStandAloneDialogTmpl<CResizableDialog>::OnEraseBkgnd(CDC * pDC)
because pDC == NULL. It could not happen according MSDN documentation
for WM_ERASEBKGND. But WM_ERASEBKGND passes through CLinkControl which
is actually subclasses parent windows of control using some custom

Attached patch converts CLinkControl to be normal control. It could
resolve these crashes, but I think this patch makes sense anyway.

[1] https://drdump.com/Bug.aspx?ProblemID=175094
[2] https://drdump.com/Problem.aspx?ProblemID=175094

Ivan Zhakov
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

Received on 2015-12-16 17:14:26 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.