Re: Manual pre-commit hook: message text empty

On 08.10.2015 13:24, M Ward wrote:
> Reproducible in latest V1.9.2:
>
> The CCommitDlg::OnBnClickedRunhook() function calls CHooks::Instance().ManualPreCommit(...) with m_sLogMessage as the message parameter.
>
> However, this value is initially empty and only gets set when the user presses the OK button, where the CCommitDlg::OnOK() function sets:
>
> m_sLogMessage = m_cLogMessage.GetText();
>
> I can verify this by creating a dummy pre_commit_hook that always exits with status 1. Now, if I press the OK button first, then the "Run hook script" button, the message I had when I pressed the OK button is what gets sent to the manual_pre_commit_hook script.
>
> If I never press the OK button, when I press the "Run hook script" button, the temp file containing the message text is always zero bytes.

Thanks for the detailed report.
Fixed in r26884.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest interface to (Sub)version control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3141471
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].