[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: undo add deletes local file causing data loss

From: Xu Hong <icehong_at_gmail.com>
Date: Sat, 5 Jul 2014 14:41:29 +0800

And also http://svn.haxx.se/tsvn/archive-2013-10/0013.shtml

I also suggest "Undo Add" do not delete file in any case.

2014-07-04 20:50 GMT+08:00 Simon Large <simon.tortoisesvn_at_gmail.com>:

> On 4 July 2014 10:20, Vajzovic, Tom <Tom.Vajzovic_at_irisys.co.uk> wrote:
> > Hi,
> >
> > Correct example 1:
> >
> > If I have an unversioned file, and select "Add" from the tortoisesvn
> context menu, then the file gets added to version control.
> >
> > If I then select "Undo Add" then the file is removed from version
> control, but the local file is left completely alone on my filesystem.
> >
> > Correct example 2:
> >
> > If I have a versioned file, and select "Delete" from the tortoisesvn
> context menu, then the file gets removed from version control and deleted
> from my local filesystem.
> >
> > Bug example:
> >
> > If I have a versioned file and from the context menu select "Rename" and
> enter a new name, then the file is renamed in version control and on my
> local filesystem.
> >
> > The renamed file is then shown with the same shell overlay as a newly
> added file. If I look at the tortoisesvn context menu "Delete" is not
> listed, but "Undo Add" is listed.
> >
> > If I select "Undo add" from the context menu then file is removed from
> version control, AND THE LOCAL FILE IS DELETED FROM MY FILE SYSTEM. If the
> local file contains uncommitted changes then this causes DATA LOSS.
> >
> > What should happen is the same as "Undo add" in the case of a
> non-renamed file: the file should be removed from version control but the
> local file should be left completely alone on my filesystem.
> >
> > Ideally a renamed file should have both "Delete" and "Undo Add" in the
> context menu. Delete should delete the file, Undo Add should just remove
> it from version control. This is a lower priority than the main issue
> though, which is just that "Undo Add" should never delete a local file.
> >
> > Please agree that this should be raised as a bug.
>
> I have raised this before some time ago.
> http://svn.haxx.se/tsvn/archive-2012-02/0004.shtml
>
> I think the argument is that it is consistent with the subversion
> command line client (Undo Add == Revert), and consistent with all
> other uses of Revert which also cause data loss in the same way. Maybe
> it is the fact that we call it 'Undo Add' instead of Revert that makes
> it seem like it should behave the same as an unversioned add.
>
> As long as you have the recycle bin enabled then the modified file
> goes there, just as it does for any other revert operation.
>
> Simon
>
> ------------------------------------------------------
>
> http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3084535
>
> To unsubscribe from this discussion, e-mail: [
> dev-unsubscribe_at_tortoisesvn.tigris.org].
>

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3084595

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2014-07-05 08:48:42 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.