RE: Undo Add and lost work

>> I would not assume that a command called "Undo Add..." ever under any
>> circumstances would delete a file.
>>
>> Proposal: When using the "Undo Add"-command on a file with copy-from
>> relations the behavior should be identically to when using it on a
>> simply added file. That is, the SVN-status should become unversioned
>> and otherwise the file should be untouched. Since the "Undo Add"
>> command is using svn revert, I guess it would require TSVN to save and
>> restore the file when the svn revert deletes it. But still I think it
>> would be the sane thing to do, from a user perspective.
>
> maybe the 'svn revert' command should change here as well? I'll ask on the svn mailing list...
> $ svn cp file1 file1_copy
> $ echo testline >> file1_copy
> $ svn revert file1_copy
> --> modifications are lost because file is gone

Yes maybe. But still; when I use the "revert" command, I am prepared that work may be lost. That is after all what "revert" mostly does. It throws away my changes.

When we call it "Undo Add" I would expect it to only, as stated, undo the "Add" operation. Nothing more. So in this case I think it would be best to either change how TSVN behaves when doing an "Undo Add", or change the name back to the more ambiguous and ominously sounding "Revert".

>> Also; I would suggest to remove the "..." from the "Undo Add..."
>> command in this case, since no confirmation dialog is shown.
> It depends: if a folder is selected, the revert dialog is shown.

Then I would suggest that the "..." is appended when a folder is selected, and not shown when only files are selected.
If that's not feasible I would opt for not having the dots there at all. Better to surprise the user with a bonus confirmation dialog, than telling them "more choices will be coming up" and then just doing the (potentially work-losing) operation right away without any confirmation step.

Hans-Emil

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3066883

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2013-10-23 08:17:35 CEST