Undo Add and lost work

Hi all!

Today a colleague lost some work when a file somewhat surprisingly disappeared. This is maybe not a bug per se, but still very unfortunate.

What happened was the following:
- A new file was created by copying (not svn-copy) an existing versioned file, and some work was done on the file.
- Then realizing that it should have been an svn-copy, the "Repair copy" function was used to add the file to svn with the correct copy-from-relation.
- Unfortunately the wrong copy from file was chosen, so he did an "Undo Add..." on the file to re-do the action, only to find that the file had been deleted and (since the recycle bin was disabled) his work lost.

I would not assume that a command called "Undo Add..." ever under any circumstances would delete a file.

Proposal:
When using the "Undo Add"-command on a file with copy-from relations the behavior should be identically to when using it on a simply added file. That is, the SVN-status should become unversioned and otherwise the file should be untouched. Since the "Undo Add" command is using svn revert, I guess it would require TSVN to save and restore the file when the svn revert deletes it. But still I think it would be the sane thing to do, from a user perspective.

Also; I would suggest to remove the "..." from the "Undo Add..." command in this case, since no confirmation dialog is shown.

Hans-Emil

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3066820

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2013-10-22 16:00:04 CEST