[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: context menu GDI leaks

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Mon, 12 Aug 2013 21:32:20 +0200

On 12.08.2013 11:25, nikos wrote:
> with TSVN installed windows explorer (and other explorer
> replacements) leak 3 GDI handles every time the folder BACKGROUND
> menu is shown. I suspect it is some of the icons shown by TSVN
>
> note this is NOT the context menu when you right click on some
> selected items (that doesn't leak) but the background folder menu,
> that is when you right click "nowhere" in explorer

I've now double and triple checked the code of the context menu handler.
There's no GDI leak in there.

The most obvious reason: there's no difference in the context menu
handler whether it's shown for a file or the folder background. The code
is the same for both. So if there's no leak for selected items, then
there's also no leak for the folder background.

Maybe some other shell extension is causing the leak, or explorer itself
(which it actually does, even on a fresh Win8 installation that GDI leak
is still there).

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest interface to (Sub)version control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3062495
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2013-08-12 21:32:28 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.