[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [tortoisesvn] r24360 committed - WhiteSpace-Fix handling:...

From: Oto BREZINA <brezina_at_printflow.eu>
Date: Wed, 12 Jun 2013 22:11:52 +0200

On 12. júna 2013 21:39, tortoisesvn_at_googlecode.com wrote:
> Revision: 24360
> Author: tortoisesvn
> Date: Wed Jun 12 12:39:24 2013
> Log: WhiteSpace-Fix handling:
> * use a separate dialog for the setup: reusing the same dialog should be
> avoided
yap but it keep things on one place I was not very convinced about its
rightness too.
> * never automatically fix: if there is something to fix, always ask first
You asked this :)
I have no access to my machine right now, but reading diif I get
feeling, that any indentation will popup fix before save dialog and
there will be no default set. In fact the other then actual will be
selected or both if mixed.
If I'm mistaken just ignore it. I'll have a look tomorrow anyway.
> * use defines instead of hard coded values
Was in plan once behaiviour get fixed ...
> CDialog::OnInitDialog();
>
> + m_trimRight.SetCheck(trimRight);
> + m_useSpaces.SetCheck(convertTabs);
> + m_useTabs.SetCheck(convertSpaces);
> + m_fixEols.SetCheck(fixEols);
> + m_EOL.EnableWindow(fixEols);

> + if ((nMap & TMERGE_WSF_ASKFIX_TABSPACE) && (convertTabs ||
> convertSpaces))
> + return true;

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3057919

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2013-06-12 22:12:07 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.