Re: UI Proposal for Code Collaborator settings

On Fri, Jun 7, 2013 at 9:22 PM, Stefan Küng <tortoisesvn_at_gmail.com> wrote:

> On 07.06.2013 21:17, friedrich brunzema wrote:
>
>> I could also detect and show this settings pg only when installed.
>> Problem with the
>> Ini file is how to set encrypted passwords.
>> Even on multiple projects, the Id and pw are not likely different.
>> Would you more comfortable with proceeding like this?
>>
>
> Not sure what problem you see storing encrypted passwords in an ini file -
> it's not much different than storing them in the registry as you do now?
>
> If you don't mind, I'll revert your change for now because it's not
> finished yet and I'd like to create the 1.8 branch.
>

Ok, I've reverted your changes for now.
And I've added crypt methods to the string utilities so you don't have to
misuse the creds class to encrypt your data.
I've also moved your class to separate files.

Now, as for where to store and get the required information:

PathToCollabGui: is that really necessary? I mean you could just request
that every user put that path to the PATH environment variable and you're
done.
RepoUrl: is that different from the repo root url? If yes is there maybe
another way to get the url?

CollabUser/Password, SvnUser/Password: why not just show a dialog asking
for that information the first time
CodeCollaboratorInfo::GetCommandLineArguments is called and those strings
are empty? Then you can store that information wherever you want.

Enabling the whole feature would be done using a project property so
projects who don't use it won't even see it.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3057588
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].