Refactoring CLogDlg::ShowContextMenuForRevisions()

All,

I'm playing around in the code - was wondering if the developer community likes the attached refactoring. I'm a bit scared, because the change (in terms of LOC) is fairly big and there are no unit tests to make sure I have not broken anything. Functionality-wise everything is still the same. Stefan caught a small bug in my last refactoring effort - thanks!

The idea is to make the method shorter and easier to understand (abstraction, information hiding)- I'm introducing a small data class to hold the local variables that are needed by the menu functionality.

I have only done minimal testing, but have found nothing amiss so far. To be thorough every context menu would need to be tested - or one could do a thorough code review.

I don't want to check this in until I hear from Stefan and/or others. I can do this type of refactoring also for the other context menu code - in that case some renaming of methods would be required. I will only make this effort if people agree that this makes the code better, otherwise there is no point.

Best,

Friedrich Brunzema

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3056442

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].