Re: [tortoisesvn] r24217 committed - * when saving, copy the file parameters first...

On 20.05.2013 11:49, Oto BREZINA wrote:
> On 2013-05-20 09:09, tortoisesvn_at_googlecode.com wrote:
>> Revision: 24217
>> Author: tortoisesvn
>> Date: Mon May 20 00:09:18 2013
>> Log: * ...
>> * remove 'using': never use that in a header file
>
> Besides those 'using's was used only once is there any issue with using
> them? I'm not going to argue about this changeset, but I don't see any
> reason for it... It was for keeping interface consistent with parent class.
>
> As I understand "using namespace" in headers is bad idea, but make
> public some parent class protected member seems be a correct use. Isn't it.

If you want to make protected members available, provide a public method.

The use of 'using' in a header can seriously mess up namespaces, and you
might end up using the wrong function/method because of it. You never
know which header includes other header files and so you don't know
which namespace you're using.
So never put 'using' in a header.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest interface to (Sub)version control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3055952
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].