Re: New and Improved: Open in Visual Studio (patch attached)

On 17.05.2013 20:21, Friedrich Brunzema wrote:
> Stefan,
>
> Wow, I'm actually a bit surprised (but pleased) that you took my
> patch mostly as is.
>
> I don't think I was leaking COM objects in my code, because I was
> using the compiler-generated smart pointers. These smart pointers
> [types ending in Ptr] use the _com_ptr_t<> class - stack based
> pointers will call Release() when they go out of scope. If you go to
> the definition of the pointer type, this becomes clear. Docs for this
> are here: [http://msdn.microsoft.com/en-us/library/417w8b3b.aspx]
>
> But changing the smart pointer kind does not matter - one could now
> possibly simplify the dte80a.tlh down to the IID's required. (This
> .tlh file was generated automatically by a #import).
>
> I'd be interested of what you think of the feature in general -
> useful? Do you still think it useful to extend this to support other
> development environment/editors in a configurable way?

Yes, I think it's useful.
And since the menu entry does not show up if VS isn't running, it
doesn't affect those who have no use for it.

As for extending this: if there is a way to make this configurable for
other editors then sure, let's do it. But it shouldn't get too complicated.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest interface to (Sub)version control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3055852
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].