Re: New and Improved: Open in Visual Studio (patch attached)

On 17.05.2013 18:31, Friedrich Brunzema wrote:
> Attached, please find the .zip file containing all the changed files.

Thanks.
Patch looks good. But I think you're leaking COM objects:
     result = ::GetActiveObject(clsid, NULL, &pUnk);
pUnk (or PDTE) is never released.
Same goes for pItemOperations a few lines down.

Committed your patch in r24196 with a few modifications:
* use of CComPtr<> to avoid the COM leaks
* changed name of menu entry to clarify that it opens the local file,
not the file as it appears in the selected revision

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest interface to (Sub)version control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3055799
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].