[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn_config_t is not thread-safe

From: Joel Jirak <joel_at_jirak.us>
Date: Mon, 3 Sep 2012 08:19:47 -0400

Here's a patch that will fix the problem. It works by un-singletoning
SVNConfig, so to speak. I'm not entirely satisfied with it because
SVNConfig then has to be created many more times than necessary. It's
more of a proof-of-concept, really.

My initial attemp was to change SVNConfig::GetConfig() to return a
copy of the config via apr_hash_copy, but this didn't work, presumably
because apr_hash_copy() does a shallow copy. I think this direction
is the cleaner way to go. Perhaps a true clone would work, but I
don't have time to investigate this now.



To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].

Received on 2012-09-03 14:19:51 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.