Re: [tortoisesvn] r23238 committed - Do not copy CFileTextLines before converting...

On 28.08.2012 21:08, Oto BREZINA wrote:
>> Is there a very, very good reason why all the already available list
>> containers are not good enough?
> I'm not sure If get All your "very", but it (altogether) reduced loading
> time by 20% (best old/worse new) or 25%(best/best) - around a second
> tested files
> Tested on CDiffData::Load (where diff takes 35% resp 50%)
>
> I can compare list performances only to get more representative results.
> But IIRC it was almost half of gain.
> Imagine all saved CO2 :)

have you tried calling reserve() on an std:vector first to avoid the
constant reallocation when loading big files? If not, then please do so
and check the timings again.

Also keep in mind that the line array is used by all views and even in
multiple threads. And your custom array isn't thread safe.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3001699
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].