[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [T-Mege bug] Comparing UTF8 and ASCII files shows changes on lines with non ASCII chars

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Thu, 23 Aug 2012 20:27:45 +0200

On Thu, Aug 23, 2012 at 8:13 PM, Stefan Küng <tortoisesvn_at_gmail.com> wrote:
> On 23.08.2012 14:23, Oto BREZINA wrote:
>>
>> On 2012-08-23 13:35, Oto BREZINA wrote:
>>>
>>> On 2012-08-22 22:10, Oto BREZINA wrote:
>>>>
>>>> On 2012-08-22 21:49, Stefan Küng wrote:
>>>>
>>>>> So should we convert all ANSI files as well?
>>>>> Or maybe just convert it if the other file has been converted or is in
>>>>> a
>>>>> different encoding?
>>>>
>>>> I thought that best would be to convert ASCII to UTF8 If encoding
>>>> differs. ASCII-ASCII and UTF8-UTF8 should be ok as is, ASCII-UTF8 is
>>>> problem.
>>>
>>>
>>> I'm going to implement it
>>
>> Should be from r23214
>>
>> What bothers me now is that EOL diff is not shown ...
>> Is that what we want ? We convert EOLs to get svn diff work. We can
>> compare EOLs when building views through.
>> Should be new option for ignore EOLs only added? - when diffing with
>> pristine instead of tmp file for example.
>
>
> When I diff the two files:
> Schiller'sGlocke_base.txt
> Schiller'sGlocke_baseCRLF.txt
>
> then the EOLs are shown properly in the view.
>
> Maybe we should just remove the option and always ignore the EOLs when
> diffing? Since they're shown in the view, it wouldn't be such a big deal.

Situation improved for the most common EOLs in r23219.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=3000542
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2012-08-23 20:28:12 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.