Re: Automatic update & commit

>>> I would like to move the core automatic commit& update code to TSVN
>>> to make it available to a much larger user base.
>> ...
>>> What would be changed in TSVN UI? - New context menu entry (top level
>>> by default?) "Automatic mode"; icon symbolizes on / off
>> I'd like to propose to add a new TortoiseSVN project property to be
>> able to disable this functionality on projects/repositories where it's
>> not desirable to use it.
...
>> The property could be called "tsvn:automaticmode" and the states could
>> be "on" (always enable automatic mode for this project), "off"
>> (never allow automatic mode on this project) or not set (default)
>> which would indicate user choice.
> I don't think that's a good idea. Here's why: if you set that property
> and disable automatic mode, then you also disable this for all read-only
> users who just want to have the updated source.

Then add a third value "read only" that makes it possible to optionally use automatic mode, but restricted to read only? That is, it would prevent automatic mode from making commits, but not prevent it from making updates.

> Imagine an open source project setting that property....

Just because it's not useful for open source projects that rely on a strict policy of who may commit to the repository doesn't mean that it isn't useful in other circumstances.

>> When I think about it I'd even go as far as saying that automatic mode
>> should probably be better disabled by default and have to be
>> explicitly enabled in the settings dialog...
> Having the option to turn this on in the submenu, not as a top-level
> menu entry should be enough in my opinion.

That would probably help somewhat. Coupled with a suitably worded confirmation dialog might be enough to stop accidental activation (and the hilarity that would ensue).

> If that's not enough, only showing the entry in the extended menu would
> help as well.

To be honest: I'm not very fond of the extended menu. (Because it is the menu that you get when holding ctrl when right-clicking, right?) It is so close to an easter egg that I wouldn't even wish it to my least favorite feature to be hidden there. :-)

>> Anyway, I think this needs some thought before TSVN with a little help
>> by some user mistakes starts flooding repositories with automated
>> commits...

How about making it possible to disable the automatic mode with a registry entry? This would (imho) be much worse than the per-project property, but would at least allow sysadmins to disable the feature on a per-workstation basis in a company if desired.

Also: It would be nice if it was possible to detect "automatic" commits in a hook script to be able to block them on that level. Perhaps some kind of (configurable?) "signature" in the commit message with some sensible default?

Maybe I'm reading way too much into this, but I really don't feel that good about the prospect of trying to manage a barrage of erroneous commits enabled by a mistaken (or misinformed) TSVN menu click.

Hans-Emil

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2964779

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2012-05-24 09:10:02 CEST