[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: compare properties changes

From: Oto BREZINA <otik_at_printflow.eu>
Date: Fri, 20 Apr 2012 22:23:30 +0200

On 2012-04-20 21:40, Stefan Küng wrote:
> On 20.04.2012 10:21, Oto BREZINA wrote:
>> Dear Stefan,
>> On commit dialog (may be in CfM and other too) you can see all changed
>> files and dir. You can see that poperty has been changed.
>> You can double click to see thoses changes what is great however:
>> * when that file have lot of changed properties and file is changed
>> too double click open lot of T-Merge window. It should be better to
>> choice what you really want to see
> It only shows the changed properties.
> What would you suggest the UI should look like for this?
> Maybe a new dialog with a list of changed properties where doubleclicks
> then open TMerge?
I thought about something like that. If there are more than three window
to open ... something like patch apply list could do that.
>> * file compare is open even there is change only in property - I
>> expect to open only changed properties
> Yes, that's by design. The same way you can double click on unversioned
> files and TMerge opens.
If you add/click on unversioned file there is some change from nothing
to file. No change no compare. I can live with this but it annoy me
sometimes when I changed property(ies) on multiple files and going over
them is closing window with no information just after double click ...
>> * when T-Merge is open with property, property can be edited, but not
>> saved
>> I expect either set right panel as readonly or allow changing
>> properties on the fly
> We had that once. But people complained: they still want to edit the
> files, because they still can save the files to somewhere else.
Readonly/writtable button (next point) would solve this.

One wonderfull feature would be to set changed property.
>> BTW- can you add switch readonly to ribbon (for every/active view)? I
>> would like to implement edit for both/all views.
>> I tried to find way how to add it, but I use VS only for TSVN so I'm not
>> very familiar with it.
>> I guess there should be three states.
>> Readonly not changable RO-disabled - propeties, base, remote revision,
>> other temp
>> Readonly but can be changed RO - comparing two files left one default
>> Writtable WR - right default
>> Not sure about tripane view, but probably only one would be editable as
>> is now.
> Do we really want this?
> If we do, we have to make some way to still allow editing, maybe via a
> new button/menu (e.g., "make editable").
My request was that to make it work I need that button. I suggest to
call it ReadOnly or Writable.
Views have attribute readonly (as r21612) this should be what gui
I thought to put this button into view header where file name and its
modification status is, but that would break clean GUI design of T-Merge.

If I'm not mistaken main remaing issues would be:
  * on exit show what files has been changed and save them. I have some
ideas about this.
  * making sure all operation works on right view too

  * save all button besides save
  * resolve use 'this and then other' when left view should be edited -
this is maybe hardest point of this.

If you are in deep doubt we can try it in brach. But I will need you
help anyway.

PS: While writting this found that setting readonly to false for view
would allow me to start testing that.

> Stefan

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2012-04-20 22:23:52 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.