[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

fixes 17-04-2012 part 2

From: <abel_at_abel.hu>
Date: Tue, 17 Apr 2012 13:31:31 +0200

Hello,

some more fixes for today.

XMessageBox
- MaxButtonStringSize wasn't big enough, so in
CXDialogTemplate::LoadUserDefinedButtonStrings all _tcscpy risked
buffer overrun (since udcs.sz* has a size of MAX_PATH).

BufferedOutFile
- InternalClose should set 'file' to INVALID_HANDLE_VALUE, because
IsOpen decides based on it. Before the patch the destructor of
CCacheFileOutBuffer could double call CloseHandle on the same handle.
First it explicitly calls RemoveFile() calling in turn
InternalClose(), then returns. When it returns the destructor of
BufferedOutFile runs, calling InternalClose() once again which did not
recognize that the file is not open anymore.)

LogDlg
- EditLogMessage had an int argument and passed it to a function
expecting a size_t. I changed the signature of EditLogMessage to have
a size_t argument.
- EditLogMessage was possibly called with -1 as argument, now it has a
check against this.

Cheers,
bel

----------------------------------------------------------------
This message was sent using IMP, the Internet Messaging Program.

Received on 2012-04-17 13:41:06 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.