[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: fixes 16-04-2012

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Mon, 16 Apr 2012 21:36:12 +0200

On 16.04.2012 21:08, Gábor Ábel wrote:
> Hi Stefan,
>
>> HistoryCombo: you're trying to use m_tooltip which doesn't exist.
>> Why are you trying to use a member variable instead of the CString we
>> use on the stack? I don't see a reason for this?
>
> I'm trying to use m_ToolText, which is added to the header file in the same patch. The CString on the stack is destroyed immediately after its internal representation is passed to m_ToolInfo.lpszText. Storing and using a pointer to an unallocated space - which not too long ago contained a string - is not a life insurance.

Ups, my fault. Completely missed the change to the header.

Committed in r22797.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2948745
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2012-04-16 21:36:18 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.