[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: fixes

From: Gábor Ábel <abel_at_abel.hu>
Date: Fri, 13 Apr 2012 00:32:21 +0200

In BaseView.patch there should be a "continue;" in the true branch of both !bDoIt, after the push_back(0), sorry.

Az iPhone készülékemről küldve.

2012.04.12. dátummal, 23:22 időpontban abel_at_abel.hu írta:

> Hi guys,
>
> here are some fixes.
>
> BaseView.patch
> - "line" variable has been set to a temporary CString object's buffer. Before the execution of the next line, this temporary object is deleted.
> - logically dead code removed
>
> FileTextLines.patch
> - ReadFile does not null-terminate the string it reads. Later pFileBuf is used as if it would be null-terminated.
>
> LocatorBar.cpp
> - checking m_pMainFrm a few lines upper implies that m_pMainFrm might be NULL. In this case dereferencing it means crash.
>
> missing_initializers.patch
> - some missing initializers in constructors.
>
> Have a nice day,
> Abel
>
> ----------------------------------------------------------------
> This message was sent using IMP, the Internet Messaging Program.
>
> <BaseView.patch>
> <FileTextLines.patch>
> <LocatorBar.patch>
> <missing_initializers.patch>

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2947845

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2012-04-13 02:10:58 CEST

This is an archived mail posted to the TortoiseSVN Dev mailing list.