Re: WM_DRAWITEM on CSplitterControl

On 04.04.2012 16:56, Sergey Azarkevich wrote:
> Hello,
>
> Seems I found bug.
>
> I can't find exact steps for reproduce problem, but it is arise
> periodically after next actions:
>
> Open Commit dialog on some versioned folder with some modified items
> and unversioned items (files and directories). Remove unversioned
> items, do refresh, switch to other applications, switch back to
> TortoiseProc.
>
> TortoiseProc crashed. This appered ~ once per 20-30 tries.
>
> I build debug version from SVN and found that program crashed due to ASSERT:
>
> atlmfc\src\mfc\winctrl1.cpp:37
>
> void CStatic::DrawItem(LPDRAWITEMSTRUCT)
> {
> ASSERT(FALSE);
> }

That's just an assert. In a release build it does nothing at all, which
means the DrawItem() method is then empty.
So it can not be the reason for the crash.

You can ignore that assert. It's triggered because of the check
hyperlink controls we have in the commit dialog, and they don't handle
the WM_*UISTATE messages. But that's not a problem since those controls
don't need those.

Your crash however could be because of this:
http://code.google.com/p/tortoisesvn/issues/detail?id=235
Try a nightly build please.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2944624
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].