[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Working copy data loss on undo add

From: Simon Large <simon.tortoisesvn_at_gmail.com>
Date: Thu, 2 Feb 2012 23:02:55 +0000

On 2 February 2012 19:28, Stefan Küng <tortoisesvn_at_gmail.com> wrote:
> On 02.02.2012 15:52, Simon Large wrote:
>> Hi Stefan,
>> I bumped into this one before but forgot to report it.
>> I svn copy and rename a file to make a variant and start editing it. I
>> decide I am going to do things a bit differently and TSVN->Undo Add.
>> This reverts the svn copy and discards the file, which is not what I
>> expected since I had edited it after making the copy.
>> What I expect Undo Add to do is:
>> Added unversioned file: Revert, but keep my original file as unversioned
>> Added file with history (unmodified): Revert, deleting the copied file
> Already works this way.

I know :-)

>> Added file with history (modified): Revert, keeping the modified file
>> as unversioned
> Not exactly: revert means also reverting local modifications.
> But: TSVN moves the reverted file to the trash bin so you *can* recover
> it if you really want to.

I know that is what it does (assuming you have the recycle bin feature
enabled), and that "Undo Add" is really just a renamed "Revert", but
IMHO it would be more consistent if it were to leave it as an
unversioned file, the same as reverting the addition of a previously
unversioned file. There is no reason to revert the changes because,
unlike reverting a simple modified file, you are not getting your
original file back again. Then again, maybe it is the subversion
library itself which is being inconsistent here.


:       ___
:  oo  // \\      "De Chelonian Mobile"
: (_,\/ \_/ \     TortoiseSVN
:   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
:   /_/   \_\     http://tortoisesvn.net
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2012-02-03 00:03:00 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.