[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: T-Merge adding goto dialog

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Fri, 25 Nov 2011 23:23:00 +0100

On 25.11.2011 23:15, Oto BREZINA wrote:
> On 2011-11-25 20:28, Stefan Küng wrote:
>> On 25.11.2011 11:04, Oto BREZINA wrote:
>>> Dear Stefan,
>>>
>>> To keep track on changes made I miss uset T-Merge as editor. I miss goto
>>> line feature, when compilation - made on other (virtual) machine gives
>>> error.
>>> I started to implement this goto line feature into T-Merge and I have
>>> sceleton ready. However my knowledge of VS is too poor to add new dialog
>>> by GUI so I copied Find dialog and made some manual changes in
>>> resources, but I know this is not good solution though.
>>> I would like to ask to help me with creating new dialog for this.
>>> I need add Ctrl-G as short cut to menu too.
>>>
>>> Attached is patch with what have been done yet. Maybe you find other
>>> design bugs.
>> Opened issue #144 for this:
>> http://code.google.com/p/tortoisesvn/issues/detail?id=144
>>
> TNx for accepting idea, I still can not create dialog properly ... I
> have to study manual probably, but have not time ...
>
> You can send me patch with goto dialog.
> Or, Here is fixed in response for your comment and you can fix that one.

I'll start on this soon.
A few comments about your patch:
* the rc and resource.h files are in utf-16 format which svn treats as
binary, so they are not included in the patch file. So I never got your
dialog.
* since the goto dialog only shows up once, and then should execute the
goto-line function after it's closed, there's no need for a special
message to send or make the dialog modeless. A simple modal dialog will do.

Stefan

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest Interface to (Sub)Version Control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2887361
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-11-25 23:23:17 CET

This is an archived mail posted to the TortoiseSVN Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.