On 28 October 2011 06:23, Jean-Marc van Leerdam
<j.m.van.leerdam_at_gmail.com> wrote:
> Simon,
>
> On 28 October 2011 00:07, Simon Large <simon.tortoisesvn_at_gmail.com> wrote:
>>
>> Hi folks,
>>
>> I have just been trying the recent speedups for the docs build and it
>> now fails for me when building the pot file.
>>
>> The problem seem to be with 2 recent changes to xml2po.py
>>
>> r15550 works OK
>> in r22174 I get these errors:
>> [echo] Checking if 'source/TortoiseSVN_en.xml' is up to date
>> [echo] Up to date
>> [echo] Creating po template from sources
>> [exec] entities replaced ( 0 , 12000 )
>> [exec] Traceback (most recent call last):
>> [exec] File "xml2po.py", line 747, in <module>
>> [exec] setTranslations()
>> [exec] File "xml2po.py", line 221, in setTranslations
>> [exec] file = open(mofile, "rb")
>> [exec] IOError: [Errno 22] invalid mode ('rb') or filename: ''
>>
>> BUILD FAILED - 0 non-fatal error(s), 7 warning(s)
>>
>> I'm guessing it was tested only in translation mode and not potfile
>> mode. potfile1.patch addresses this, but I'm not sure the test is
>> optimal.
>>
> Sorry about that, you are correct. The test is fine.
Thanks for the review, and to Lübbe for committing. I have backported
this and Oto's indentation fixes to the 1.7.x branch so that now
builds OK too.
Simon
--
: ___
: oo // \\ "De Chelonian Mobile"
: (_,\/ \_/ \ TortoiseSVN
: \ \_/_\_/> The coolest Interface to (Sub)Version Control
: /_/ \_\ http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2867258
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-10-29 21:54:28 CEST