Hi All,
I have just started using the nightly build in my work environment so have had a look at the
new external property editing dialog. This is a nice improvement and should reduce the
hassle that some of my colleagues have with externals.
However there are a few things that I can see to improve the dialog:
The repository browse button.
This seems to return the full path even though it can start with a repository relative
path. Is there any way that we can get this to leave the url in the same form as it was.
ie. If it starts with a ^ / or // then these will still be there after the browsing is
complete.
It would also be nice to leave out the :@ from the domain name if there are no user
and password details. I believe that this is confusing to users.
Also this system does not seem to handle scheme relative addresses ( starting with //
). Using this opened a file browse dialog rather than the repo browser.
I can see in the code that there are calls to ShowEditBalloon() on errors, but this
does not seem to show anything on my system ( Windows XP ). Errors in the
revision box just end up with a dialog that doesn't close when the OK button is
pressed.
Handling of operative revision.
I believe that the best practice is to use the peg revision to select which revision to
use for externals. This is because it is more stable in the face of renames to the url
that occur after the revision of interest. With this thought I think the show log button
should be attached to the peg revision not the operative revision as this is the one that
users should be adjusting.
Changing the operative revision is really only for people who know what they are
doing so I would actually be happy if this was not on the dialog at all. The problem of
course is begin able to parse existing external information into the dialog for editing
so I suppose we can't remove it as there are a lot of external definitions that have this
revision informaiton rather than the peg revision.
If the revision field has 'HEAD' in it then the revision is left empty. This is not
correct as an empty operative revision means use the peg revision. I suggest that the
label 'HEAD revision' should be changed to 'Same as peg revision' as that is the way
the current code works. But it doesn't look good with this changed and will take some
explaining.
Tested with:
TortoiseSVN 1.7.99, Build 22065 - 32 Bit -dev, 2011/10/10 09:03:55
Thanks for a great program.
Alan
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2853235
To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-10-11 11:17:27 CEST